Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handler: unwrap errors using errors.As #1209

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

mcdoker18
Copy link
Contributor

A datastore may wrap errors with additional information. Before the fix, the error was converted to the InternalServerError type by the handler.

A datastore may wrap errors with additional information. Before the fix,
the error was converted to the InternalServerError type by the handler.
pkg/handler/patch_test.go Outdated Show resolved Hide resolved
Copy link
Member

@Acconut Acconut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Acconut Acconut changed the title handler: use errors.As when casting an error to handler.Error handler: unwrap errors using errors.As Oct 22, 2024
@Acconut Acconut merged commit 47b53ab into tus:main Oct 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants