Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handler: Pass request context to logger when logging #1237

Merged
merged 2 commits into from
Jan 14, 2025
Merged

handler: Pass request context to logger when logging #1237

merged 2 commits into from
Jan 14, 2025

Conversation

mmhand123
Copy link
Contributor

This allows the logger passed to the tusd handler to access the request specific context and pull out things like sentry information or trace information. Implements #1236

@mmhand123
chore: Pass request context to logger when logging
d33068b 
This allows the logger passed to the tusd handler to access the request
specific context and pull out things like sentry information or trace
information. Implements tus#1236
Acconut
Acconut requested changes Jan 14, 2025
View reviewed changes
Copy link
Member

@Acconut Acconut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this quick PR. One minor note, then we can merge this.

pkg/handler/unrouted_handler.go Outdated Show resolved Hide resolved
Acconut
Acconut approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@Acconut Acconut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your work!

@Acconut Acconut merged commit d69efe0 into tus:main Jan 14, 2025
7 checks passed
@Acconut Acconut linked an issue Jan 14, 2025 that may be closed by this pull request
Pass request context to the logger #1236
Closed
@Acconut Acconut mentioned this pull request Jan 14, 2025
Closed
@mmhand123
Copy link
Contributor Author

Thank you very much for your work!

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Acconut Acconut Acconut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass request context to the logger
2 participants
@mmhand123 @Acconut