Properly summarize all notifications #4848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lakoja
commented
Jan 4, 2025
app/src/main/java/com/keylesspalace/tusky/components/systemnotifications/NotificationFetcher.kt
Outdated
Show resolved
Hide resolved
Lakoja
force-pushed
the
only-one-notification-per-type
branch
from
b0eb031 to
d4157fc
Compare
connyduck
reviewed
Jan 7, 2025
...src/main/java/com/keylesspalace/tusky/components/systemnotifications/NotificationHelper.java
Show resolved
Hide resolved
app/src/main/java/com/keylesspalace/tusky/components/systemnotifications/NotificationFetcher.kt
Show resolved
Hide resolved
app/src/main/java/com/keylesspalace/tusky/components/systemnotifications/NotificationFetcher.kt
Show resolved
Hide resolved
Lakoja
force-pushed
the
only-one-notification-per-type
branch
from
d4157fc to
5b872a1
Compare
connyduck
reviewed
Jan 11, 2025
Comment on lines
109
to
112
| notificationManagerCompat.notify(newNotifications) | ||
|
|
||
| // NOTE this can schedule multiple (summary) notifications in short succession (normally 1-3). | ||
| // They can "collapse" to only one audible one if fast enough. |
There was a problem hiding this comment.
Could this be outside of the notificationsByType.forEach loop as well?
Lakoja
force-pushed
the
only-one-notification-per-type
branch
from
c585e25 to
0fa77a1
Compare
|
Tested this now on my (Android 14) device. Seems to work reasonably well. There are of course still odd edge-cases. For example if there are a very many notifications of different types, you will only get one summary. For example "25 favorite notifications" but nothing more. |
connyduck
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do summary notifications like the Api defines it:
Testing this is probably the most difficult part.
For example I couldn't get any notification to ring with older Api versions in the debugger. (Same as for current develop)
However one hack to always get notifications: Fix "minId" in "fetchNewNotifications()" to a somewhat older value.
Next possible step: Have only one summary notification at all (for all channels/notification types). You can still configure single channels differently.
Or: For very many notifications: Only use a true summary one (something like "you have 28 favorites and 7 boosts").
Generally: The notification timeline must be improved now. Because that must be the go-to solution for any large number of notifications. It must be easy to read. E. g. with grouping per post.