Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define code acesses for calendar and mail app #7240

Open
wants to merge 33 commits into
base: dev-calendar
Choose a base branch
from

Conversation

domesticated-raptor
Copy link
Contributor

No description provided.

andrehgdias and others added 30 commits July 9, 2024 09:27
This commit creates the base android project to the Calendar
App.

It's the same as the mail app with less permission and without
mailto and vcard handling

Closes #7145

Co-authored-by: Murilo Pereira <[email protected]>
Co-authored-by: @rih-tutao
Co-authored-by: @rih-tutao
Co-authored-by: @rih-tutao
This commit splits the settings files in:
 - Common for components and screen used by both apps;
 - Mail for settings related with the mail app;
 - Calendar for settings related with the calendar app.

 Co-authored-by: Murilo Pereira <[email protected]>
This commit fixes the Android project changing the gradle task
used to build the Android app.

Also fixes some import errors caused by the rebase.

Co-authored-by: Murilo Pereira <[email protected]>
This commit prevents the redraw event from being fired when the sidebar is scrolled.
The redraw isn't needed since we change the dom directly through target.

Co-authored-by: André Dias <[email protected]>

Fixes #7179
This commit adds the contacts permission page instead of the contacts
import and sync when using the Calendar app. The permission is needed
to suggest contacts when creating an event and inviting guests.

Co-authored-by: André Dias <[email protected]>

Fixes #7150
The calendar app doesn't have email or contacts, so it shouldn't
handle search for these entities. This commit removes the Mail/Contact search
and also fixes a bug related to calendar search skipping same day events.

Co-authored-by: André Dias <[email protected]>

Fixes #7155
…ter bugs

Fixes calendar not selecting an event when the event ID is present in the URL.
Also fixes the calendar selection that was throwing an error when moving back
to All calendars

Co-authored-by: André Dias <[email protected]>
This commit adds a check before changing the selected calendar in SearchView
to prevent checking for Calendar values when selecting all calendars.

This commit also fixes the item selection when page loads by subscribing to
a stream and awaiting the list load before selecting a result.

Co-authored-by: André Dias <[email protected]>
This commit modifies the Calendar App icon to use the new icon
instead of using the same as the current mail app.

Co-authored-by: André Dias <[email protected]>

Closes #7148
Co-authored-by: @rih-tutao
This commit splits the settings files in:
 - Common for components and screen used by both apps;
 - Mail for settings related with the mail app;
 - Calendar for settings related with the calendar app.

 Co-authored-by: Murilo Pereira <[email protected]>
This commit fixes the Android project changing the gradle task
used to build the Android app.

Also fixes some import errors caused by the rebase.

Co-authored-by: Murilo Pereira <[email protected]>
This commit adds the App field to push identifiers, letting the
server know if the identifier belongs to Mail or Calendar app and
send notifications correctly according to the app.

Closes #7149
mup and others added 3 commits July 18, 2024 11:43
@domesticated-raptor
Copy link
Contributor Author

I clarified with @charlag, in the ideal situation we would have a separate config for common and include that is a module (so common can only reference code inside common) but this setup would be fine for the initial release.

@wrdhub wrdhub force-pushed the dev-calendar branch 3 times, most recently from 0f0ba8c to 4919979 Compare July 26, 2024 15:49
@andrehgdias andrehgdias force-pushed the dev-calendar branch 3 times, most recently from 9c34018 to 6e18a0c Compare September 23, 2024 08:04
@andrehgdias andrehgdias force-pushed the dev-calendar branch 2 times, most recently from 565dc82 to 50e3012 Compare September 23, 2024 15:14
@murilopereirame murilopereirame force-pushed the dev-calendar branch 2 times, most recently from 0867c19 to 1e62b32 Compare November 29, 2024 11:02
@murilopereirame murilopereirame force-pushed the dev-calendar branch 2 times, most recently from 03d4af3 to bc0e451 Compare December 9, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants