-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced repeat rules UI #8422
Open
Patrik-wav
wants to merge
98
commits into
8046-parse-advanced-repeat-rules
Choose a base branch
from
8047-advanced-repeat-rules-ui
base: 8046-parse-advanced-repeat-rules
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Advanced repeat rules UI #8422
Patrik-wav
wants to merge
98
commits into
8046-parse-advanced-repeat-rules
from
8047-advanced-repeat-rules-ui
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit change the URL validation removing the support for HTTP unsecure protocol.
Fixes short events that are cut off in the next month due to the random shift by generating them until their end date instead of the load range. Co-authored-by: rih <[email protected]>
Co-authored-by: and <[email protected]>
Co-authored-by: rih <[email protected]>
Co-authored-by: Murilo Pereira <[email protected]>
Adds a new base select component with two variants (Expanded or not). The select is capable of rendering custom children provided by a render function. Co-authored-by: André Dias <[email protected]>
Co-authored-by: André Dias <[email protected]>
Co-authored-by: André Dias <[email protected]>
Co-authored-by: André Dias <[email protected]> Co-authored-by: rih <[email protected]>
This commit adds a button that has a label and when clicked/focused will render an input. Also makes the SingleLineTextField more complaint with accessibility by allowing it to receive an aria-label.
This commit adds the reminder section to the new event editor. Also address changes on the Select component to comply with our current existing layout.
Modifies the existing Time Picker to use the new components. Also adapts the DatePicker to support both variants (old and new). Both components where adapted to be accessible on mobile devices and desktop when using keyboard navigation. Co-authored-by: Murilo Rocha Pereira <[email protected]>
Adds slide transition to Dialog and fixes accessibility issues with RadioGroup. Also adds the possibility of RadioGroup receive and handle an injection map according to its options. Co-authored-by: Murilo Pereira <[email protected]> Co-authored-by: rih <[email protected]>
This commit implements the Guest Pages and the GuestPicker, allowing to invite guests when creating a new event. Also fixes the Reminder selector not correctly handling the custom option due event loop race conditions. Co-authored-by: rih <[email protected]>
Co-authored-by: André Dias <[email protected]> Co-authored-by: rih <[email protected]>
Co-authored-by: André Dias <[email protected]>
Co-authored-by: André Dias <[email protected]>
The value fill-available isn't available on all browsers in a universal way yet, so we'd to revert.
Replaces the computedStyles call and fixes the padding to avoid incompatibilities between platforms. Co-authored-by: ivk <[email protected]>
Co-authored-by: André Dias <[email protected]>
Co-authored-by: André Dias <[email protected]>
Some rules aren't supported during event creation/editing. This commit adds an info banner warning about losing rules if user edits and event with unsupported rules. Co-authored-by: André Dias <[email protected]>
Co-authored-by: pas <[email protected]>
Introduce WeekdaySelectorButton component
Currently, reading BYDAY Rules from an existing event works, however writing them has not been added yet.
Upon closing the editor it now passes the values to the model
WeekRepetitionSelector component still needs to be finished and hooked up to the CalendarWhenModel
Fix undefined weekdays being written on AdvancedRules
murilopereirame
force-pushed
the
8046-parse-advanced-repeat-rules
branch
2 times, most recently
from
February 3, 2025 08:23
c8134f0
to
040498f
Compare
tutao-mac
force-pushed
the
8046-parse-advanced-repeat-rules
branch
2 times, most recently
from
February 3, 2025 08:45
30a7bb4
to
7aefc39
Compare
murilopereirame
force-pushed
the
8046-parse-advanced-repeat-rules
branch
2 times, most recently
from
February 4, 2025 06:54
ffbc61b
to
be4c63a
Compare
tutao-mac
force-pushed
the
8046-parse-advanced-repeat-rules
branch
from
February 4, 2025 07:13
be4c63a
to
e3da4ff
Compare
murilopereirame
force-pushed
the
8046-parse-advanced-repeat-rules
branch
from
February 4, 2025 08:05
a0e43a2
to
4ff0a1d
Compare
tutao-mac
force-pushed
the
8046-parse-advanced-repeat-rules
branch
3 times, most recently
from
February 5, 2025 12:25
cf65d58
to
7446664
Compare
murilopereirame
force-pushed
the
8046-parse-advanced-repeat-rules
branch
3 times, most recently
from
February 6, 2025 13:01
25f09c9
to
6e404da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8047