Advanced repeat rules #8456
Open
Advanced repeat rules #8456
+8,786
−217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murilopereirame
force-pushed
the
8046-parse-advanced-repeat-rules
branch
from
c8134f0 to
040498f
Compare
tutao-mac
force-pushed
the
8046-parse-advanced-repeat-rules
branch
2 times, most recently
from
30a7bb4 to
7aefc39
Compare
murilopereirame
force-pushed
the
8046-parse-advanced-repeat-rules
branch
3 times, most recently
from
ffbc61b to
be4c63a
Compare
tutao-mac
force-pushed
the
8046-parse-advanced-repeat-rules
branch
from
be4c63a to
e3da4ff
Compare
murilopereirame
force-pushed
the
8046-parse-advanced-repeat-rules
branch
from
a0e43a2 to
4ff0a1d
Compare
tutao-mac
force-pushed
the
8046-parse-advanced-repeat-rules
branch
2 times, most recently
from
58728cf to
3d6d998
Compare
murilopereirame
force-pushed
the
8046-parse-advanced-repeat-rules
branch
from
39d4116 to
cf65d58
Compare
tutao-mac
force-pushed
the
8046-parse-advanced-repeat-rules
branch
from
cf65d58 to
7446664
Compare
andrehgdias
force-pushed
the
dev-calendar
branch
from
d07a5cf to
167c8dd
Compare
murilopereirame
force-pushed
the
dev-calendar
branch
from
167c8dd to
dbbf01a
Compare
murilopereirame
force-pushed
the
8046-parse-advanced-repeat-rules
branch
2 times, most recently
from
5ca250b to
c9c0d40
Compare
Co-authored-by: André Dias <[email protected]>
Co-authored-by: André Dias <[email protected]>
Co-authored-by: André Dias <[email protected]>
Co-authored-by: André Dias <[email protected]>
Co-authored-by: André Dias <[email protected]>
This commit simplifies the Event Generator, removing duplicated code that are not needed.
Co-authored-by: paw-hub <[email protected]>
Co-authored-by: André Dias <[email protected]>
Co-authored-by: André Dias <[email protected]>
Some rules aren't supported during event creation/editing. This commit adds an info banner warning about losing rules if user edits and event with unsupported rules. Co-authored-by: André Dias <[email protected]>
Co-authored-by: pas <[email protected]>
To have the SDK we must move the tests from unit to Instrumented Tests as unit tests aren't able to load our compiled SDK since the target mismatches (Unit tests require linux-x86-64). Mockito isn't able to mock final classes and instead of making all of them open, we can use dexmaker to proxy the classes and be able to fully mock final classes. This commit introduces dexmaker as a dependency and also overrides dexmaker mockito-core with a more updated one.
murilopereirame
force-pushed
the
8046-parse-advanced-repeat-rules
branch
from
c9c0d40 to
25f09c9
Compare
The way that we count events and occurrences changed with the implementation of the advanced repeat rules, given that, we've had to fix tests that relies on these counts. This commit address one corner case for weekly events expansion on SDK and fixes the tests on Swift.
murilopereirame
force-pushed
the
8046-parse-advanced-repeat-rules
branch
from
25f09c9 to
6e404da
Compare
charlag
reviewed
Feb 6, 2025
| } | ||
|
|
||
| trait MonthNumber { | ||
| fn to_number(&self) -> u8; |
charlag
reviewed
Feb 6, 2025
| &self, | ||
| date: DateTime, | ||
| repeat_rule: EventRepeatRule, | ||
| ) -> Vec<DateTime> { |
There was a problem hiding this comment.
would making an iterator make more sense, like we do with JS or Swift?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.