8459 convo actions label read export #8467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
wrdhub
force-pushed
the
8459-convo-actions-label-read-export
branch
2 times, most recently
from
8b7a382 to
d756690
Compare
charlag
reviewed
Feb 4, 2025
src/mail-app/mail/model/MailModel.ts
Outdated
| @@ -432,6 +433,11 @@ export class MailModel { | |||
| return !this.logins.isEnabled(FeatureType.DisableMailExport) | |||
| } | |||
|
|
|||
| async loadAndMarkMails(mails: () => Promise<readonly Mail[]>, unread: boolean): Promise<void> { | |||
There was a problem hiding this comment.
load methods seems like they should not be on the MailModel. I know you are probably trying to reduce duplication but we should think about it again I guess.
paw-hub
force-pushed
the
8223-conversation-list-model
branch
5 times, most recently
from
cd43326 to
f71566a
Compare
charlag
reviewed
Feb 6, 2025
charlag
force-pushed
the
8223-conversation-list-model
branch
from
2ee60b2 to
dfb4d04
Compare
wrdhub
force-pushed
the
8459-convo-actions-label-read-export
branch
2 times, most recently
from
3458d59 to
214d1c0
Compare
charlag
force-pushed
the
8223-conversation-list-model
branch
from
980e994 to
c0d7723
Compare
Base automatically changed from
8223-conversation-list-model
to
conversation-integration
February 6, 2025 16:29
Makes it different from MailListView component so it is easier to search
charlag
force-pushed
the
8459-convo-actions-label-read-export
branch
from
214d1c0 to
3797817
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.