Handle "Could not access secret storage" error gracefully #8471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keys can get corrupted and become unusable, causing users to get stuck with a broken installation. Currently we can't distinguish temporary errors from persistent breakage. The easiest solution for now is just to give the user a choice when the error occurs. Restart -> in case of a temporary error caused by user's setup. Continue -> on the off-chance deviceKey is broken and user can log in. Clear local data -> deletes config and invalidates keychain to allow user to enter credentials again. Close #8380 Co-authored-by: ivk <[email protected]>
hrb-hub
force-pushed
the
8380-corrupted-secret-storage
branch
from
018678c to
63acfa7
Compare
charlag
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keys can get corrupted and become unusable, causing users to get stuck with a broken installation.
Currently we can't distinguish temporary errors from persistent breakage. The easiest solution for now is just to give the user a choice when the error occurs.
Restart -> in case of a temporary error caused by user's setup.
Continue -> on the off-chance deviceKey is broken and user can log in.
Clear local data -> deletes config and invalidates keychain to allow user to enter credentials again.
Close #8380