-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdownlint fixes #30812
Markdownlint fixes #30812
Conversation
@mdo did you use my branch https://github.com/twbs/bootstrap/tree/master-xmr-markdownlint? Because there are false positives Markdownlint cannot handle hence why I haven't made a PR to actually add Markdownlint. EDIT: here's the upstream issue DavidAnson/markdownlint#249 |
I didn't use your branch—I use markdownlint at GitHub and just ran the CLI against our docs to clear out the easy wins. There are tons of false positives due to our docs tags and what not. |
README.md
Outdated
[](https://opencollective.com/bootstrap/sponsor/7/website) | ||
[](https://opencollective.com/bootstrap/sponsor/8/website) | ||
[](https://opencollective.com/bootstrap/sponsor/9/website) | ||
[](https://opencollective.com/bootstrap/sponsor/0/website) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if "OC Sponsor" is better than nothing. @patrickhlauke
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so i take it there's no way for us to somehow get that pulled in via third party or something and have it provided with more accurate alt etc? (like a validation badge or similar that actually gets generated separately and dynamically pulled in)
if not, then...yeah, better than nothing i guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, I'm not aware of a way. But perhaps we should use OC sponsor 1
etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess you could. that would still not provide the equivalent of what sponsor it is, but i guess it would at least indicate it's not always the same image. least worst fix, probably
I have disabled some rules in my branch https://github.com/twbs/bootstrap/runs/589127421#step:9:235 |
To clarify, this isn't meant to add a script or Action anywhere—it's just cleaning up some Markdown :). I'll defer to another PR for implementing it and running it as a check for us everywhere. |
I know, just trying to get the best of the two branches :) So, you prefer a That being said, let's wait to hear about the |
@patrickhlauke friendly ping :) |
- Always use dashes for bullets - Add some basic alt text for our readme OC sponsors
af3734d
to
849e018
Compare
Addresses some Markdown linting found from testing out
markdownlint
in #29919.