[RFC007] Migration of the typechecker - part II #2134
Draft
+6,553
−13,091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new AST borrows from an allocator, which causes a whole lot of issues in the cache and requires a profound re-architecturing. This commit start this migration by splitting the cache into smaller, more manageable parts, and a specific sub-structure that holds the ASTs and their allocators, which requires a bit of unsafe code.
And add a bunch of ugly debug println to help with the failing tests that are inevitably coming.
…ge the typechecker quite a bit)
yannham
force-pushed
the
rfc007/typechecking-part-2
branch
from
99e6dac to
ec75835
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. This PR continues #2121. The goal is to scrap the old typecheck module, and update whatever needs to be updated in order to use the migrated
bytecode::typecheckinstead.Doing so, I realize that NLS isn't the only obstacle: the migration of the source cache isn't entirely trivial, given the allocator approach of the new AST.