remove ocamlgraph #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocamlgraph needs autoconf if we want to use ./configure, and currently fails since autoconf isn't a build input (at least on MacOS). But I confirmed it works statically if we just remove this override altogether, as the project now supports building with straight dune: https://github.com/backtracking/ocamlgraph/blob/master/INSTALL.md
balsoft
reviewed
Apr 18, 2024
Comment on lines
-68
to
-75
| ocamlgraph = oa: { | ||
| buildPhase = '' | ||
| ./configure | ||
| sed 's/graph.cmxs//' -i Makefile | ||
| make NATIVE_DYNLINK=false | ||
| ''; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Are you sure that it will build statically on Linux without this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ocamlgraph needs autoconf if we want to use ./configure, and currently fails since autoconf isn't a build input (at least on MacOS). The project now supports building with straight dune:
https://github.com/backtracking/ocamlgraph/blob/master/INSTALL.md
I confirmed this via building an executable that pulls it in, and checked with otool that it didn't link to anything else