feat(gateway): support zstd-stream
#2400
Open
+294
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilgotf
added
t-feature
github-actions
bot
added
c-book
vilgotf
force-pushed
the
vilgotf/zstd
branch
from
5e2c486 to
98b8ae9
Compare
It was how we used to do it, but we had multiple people ask for ways to disable it thus we made it optional in #700. |
vilgotf
force-pushed
the
vilgotf/zstd
branch
2 times, most recently
from
2d33124 to
444a108
Compare
vilgotf
changed the title
zstd-stream
vilgotf
force-pushed
the
vilgotf/zstd
branch
3 times, most recently
from
57edeaa to
6bd7057
Compare
Erk-
approved these changes
Jan 31, 2025
Comment on lines
+136
to
+138
| self.ctx | ||
| .reset(zstd_safe::ResetDirective::SessionOnly) | ||
| .expect("resetting session is infallible"); |
There was a problem hiding this comment.
I think this is good for now, but if we see memory grows over time or something we should switch it to just recreating the ctx.
Co-authored-by: Erk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
zstd-stream1 transport compression using Facebook's reference implementation (written in C) and deprecates ourzlib-streamsupport.I did not run into any build dependency issues on macOS, Linux, or Windows as Zstd-safe seems to statically link against Zstd. Otherwise there is a pure Rust implementation of Zstandard called ruzstd which we may eventually switch to.
This PR deprecates the
zlib-stockandzlib-simdfeatures since they are replaced by thezstdfeature. While doing this, I opted to not expose the previousInflatertype and itsprocessedandproducedproperties as those are not tracked by Zstd itself.Edit: more radically, should we unconditionally use Zstd transport compression? It's like an implementation detail (or a foot gun).
Update: no, transport compression is bad for shards behind a Gateway proxy.
Footnotes
https://discord.com/blog/how-discord-reduced-websocket-traffic-by-40-percent ↩