Adds links to media in email when forwarding to SendGrid #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, @philnash, this works. Thank you. I agree that, ideally, the media would be email attachments. I seem to recall somewhere in Twilio's exhaustive documentation that the media files also have to be explicitly deleted from Twilio's servers, but I could not find the cost or limit on that storage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to #92 when sending a message consisting of just media content the
forward-to-sendgridfunction errors. This PR will create an email body out of the message body and any media URLs that have been sent.More ideal would be downloading and attaching the media. This is a quickish fix for now.
Does this work for you @jeremiahlee?
Checklist
npm testlocally and it passed without errors.Related issues
#92