Preserve full URL when using 'anchor' function. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,6 +17,6 @@ function anchor(props, text) { | |||
| return h('a', props, text); | |||
|
|
|||
| function pushState() { | |||
| routeAtom.set(href); | |||
| routeAtom.set(props.href); | |||
added 5 commits
September 4, 2015 17:19
This replaces the use of '#' in 'href' attributes, while making sure the link is intercepted by the router.
|
@twilson63, fwiw - this patch is ok we've been using this for the last couple of weeks without issues. |
twilson63
pushed a commit
that referenced
this pull request
Sep 17, 2015
Preserve full URL when using 'anchor' function.
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the url is replaced with hash, which has a negative impact on usability - i.e. you're not able to ctrl+click to open up a link in a new tab etc. With this patch the full url is rendered, while still being intercepted by mercury-router so you don't get an app-reload by clicking them directly.
lib/router.jsinto readme.md. And removed the old one.