-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow use of public_suffix
5
#155
Conversation
Hmm, maybe this part needs some tweaking after sporkmonger/addressable#459 twingly-url/lib/twingly/url.rb Lines 94 to 104 in 767807a
Haven't looked into it, I'll leave that to the real maintainers :-) |
Maybe this method isn't needed anymore after the updated requirements in 5ae3a68, but as I understand it sporkmonger/addressable#224 isn't completely solved yet. We don't have any URLs in the specs that fails on the |
Changes in public_suffix looks fine to me, no breaking API changes what I can see: * https://github.com/weppos/publicsuffix-ruby/blob/v5.0.0/CHANGELOG.md#500 * weppos/publicsuffix-ruby@v4.0.7...v5.0.0 Addressable 2.8.1 was just released to allow use of public_suffix 5.x: https://github.com/sporkmonger/addressable/blob/addressable-2.8.1/CHANGELOG.md#addressable-281
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Changes in
public_suffix
looks fine to me, no breaking API changes what I can see:Addressable 2.8.1 was just released to allow use of public_suffix 5.x:
https://github.com/sporkmonger/addressable/blob/addressable-2.8.1/CHANGELOG.md#addressable-281