Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kgo: fix potential deadlock when reaching max buffered (records|bytes) #832

Merged
merged 2 commits into from
Oct 10, 2024
Merged

kgo: fix potential deadlock when reaching max buffered (records|bytes) #832

merged 2 commits into from
Oct 10, 2024

Commits on Oct 10, 2024

  1. kgo: fix potential deadlock when reaching max buffered (records|bytes) 

    Problem:
* Record A exceeds max, is on path to block
* Record B finishes concurrently
* Record A's context cancels
* Record A's goroutine waiting to be unblocked returns, leaves accounting mutex in locked state
* Record A's select statement chooses context-canceled case, trying to grab the accounting mutex lock

See #831 for more details.

Closes #831.
    @twmb
    twmb committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6a75940 View commit details
    Browse the repository at this point in the history

  2. all: unlint what is now cropping up 

    gosec ones are delibate; govet ones are now randomly showing up (and
also deliberate)
    @twmb
    twmb committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    0de933b View commit details
    Browse the repository at this point in the history