Doug/create data loader #2
Conversation
|
Model Type: DummyClassifier Train Data Length: 445982 f1_score - 0.000000
|
There was a problem hiding this comment.
Thanks @dgjlindsay! Just a few minor things mostly related to getting the CI to pass.
Also could you run black over these files as well?
| DEFAULT_OBJECT_NAME = 'bs140513_032310.csv' | ||
|
|
||
| def load_data(object_name: str = None): | ||
| object_url = BUCKET_URL + (object_name or DEFAULT_OBJECT_NAME) |
There was a problem hiding this comment.
Could you add a docstring for this function, so that interrogate is happy? 🙂
| @@ -0,0 +1,33 @@ | |||
| from unittest.mock import patch, Mock | |||
|
|
|||
| from util.data_access import load_data, DEFAULT_OBJECT_NAME, BUCKET_URL | |||
There was a problem hiding this comment.
I think this may require a full path, so src.util.data_access, for the tests to pass in the GitHub action.
There was a problem hiding this comment.
Fixed the CI PYTHONPATH instead, so that we can import like this without the "src" prefix
src/util/data_access.py
Outdated
| @@ -0,0 +1,8 @@ | |||
| import pandas | |||
There was a problem hiding this comment.
Very minor, but the convention for pandas usage is to import it as pd
|
Model Type: DummyClassifier Train Data Length: 445982 f1_score - 0.000000
|
|
Model Type: DummyClassifier Train Data Length: 445982 f1_score - 0.000000
|
|
Model Type: DummyClassifier Train Data Length: 445982 f1_score - 0.000000
|
|
Model Type: DummyClassifier Train Data Length: 445982 f1_score - 0.000000
|
|
Model Type: DummyClassifier Train Data Length: 445982 f1_score - 0.000000
|
|
Model Type: DummyClassifier Train Data Length: 445982 f1_score - 0.000000
|
|
Model Type: DummyClassifier Train Data Length: 445982 f1_score - 0.000000
|
|
Model Type: DummyClassifier Train Data Length: 445982 f1_score - 0.000000
|
|
Model Type: DummyClassifier Train Data Length: 445982 f1_score - 0.000000
|
|
Model Type: DummyClassifier Train Data Length: 445982 f1_score - 0.000000
|
No description provided.