Update supertrend to match Tradinview indicator #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, lowerband (lb) and upperband (ub) should be updated with previous value (if condition is met) despite change direction (dir_) occurs or not. This change match with supertrend TradingView indicator.
|
Thanks @egrafeuille! I will check it out as soon as I can. KJ |
|
any chance to merge this one? |
|
Hello @GSLabIt, Do not wait for me. Update your local code in the mean time with the code provided if it works for you. In the long run, supertrend, qqe, et al that are computationally dense loops will be converted to numba to boost performance. KJ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
lowerband (lb) and upperband (ub) should be updated with previous value (if condition is met) despite change direction (dir_) occurs or not. This change match with supertrend TradingView indicator.