Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing Foundation + OrderedCollection imports #278

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

goergisn
Copy link
Contributor

@goergisn goergisn commented Jan 18, 2025

Background

The project did fail building using BUILD_LIBRARY_FOR_DISTRIBUTION=YES due to missing imports

Here the command to verify:
xcodebuild clean build -scheme "Ignite" -derivedDataPath .build BUILD_LIBRARY_FOR_DISTRIBUTION=YES -destination "generic/platform=macOS" -skipPackagePluginValidation OTHER_SWIFT_FLAGS=-no-verify-emitted-module-interface

Changes

  • Adding missing imports to allow building the package with library evolution enabled

Notes

  • It might be helpful to add a github workflow that checks for a successful build using that setup to not break in the future

@JPToroDev JPToroDev merged commit 17e7c0a into twostraws:main Jan 18, 2025
1 check passed
@JPToroDev
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants