add Modal tests #357
add Modal tests #357
Conversation
|
Thank you! I have added the conformances for you – does that help? Also, please make sure you run SwiftLint on your code before committing. |
|
Regarding the misspelling: Could you please open an issue for that? It would let us track it more easily. Thank you! |
|
@twostraws Thank you for fixing! I will modify my test codes and run swiftLint. |
|
@twostraws I fixed test cases. Please check it. |
| } | ||
|
|
||
| @Test("Modal Size Test", | ||
| arguments: [Modal.Size.small, Modal.Size.medium, Modal.Size.large, Modal.Size.xLarge, Modal.Size.fullscreen]) |
There was a problem hiding this comment.
I've added CaseIterable conformance to Modal.Size for you. Could you update this to Modal.Size.allCases?
There was a problem hiding this comment.
@JPToroDev Thank you for your help.
| } | ||
| } | ||
|
|
||
| @Test("Modal Position Test", arguments: [Modal.Position.top, Modal.Position.center]) |
There was a problem hiding this comment.
You can use allCases here too if you'd like, but this isn't as verbose as above.
There was a problem hiding this comment.
@JPToroDev It doesn't seem to need allCases only for testing, yet I modified.
|
Is this good to merge? |
|
@JPToroDev Yes, please! Sorry for my replying late. |
|
Thank you – this is great work! |
@twostraws I added Modal tests.
As
Modal.SizeandModal.Positionhave Sendable protocol issues(does not conform to the 'Sendable' protocol), I did't use arguments option forcheckModalSizes()andcheckModalPosition().Is it OK?
I found the option sample contains misspelling
[.backdrop(dismissable: false)]. Please check it.