Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased stability of SiteTests #446

Conversation

erikbasargin
Copy link
Contributor

This PR addresses #445 issue, and continuation of #438.

* `publishingWithNoMarkdownContent` updated/renamed with `publishingWithMarkdownContent` to accurately represent what the test does.
* Increased stability of SiteTests
* Added warning to the SiteTests suite documentation
@erikbasargin erikbasargin force-pushed the fix-site-publish-when-content-with-invalid-lastModified branch from f283af6 to 499c606 Compare January 31, 2025 08:38
@erikbasargin
Copy link
Contributor Author

erikbasargin commented Jan 31, 2025

The fix has been removed in favour of #448. Here are still some SiteTests updates that increase stability of the tests, and a note that point to a bigger issue with depending on PublishingContext.default across unit tests.

Regarding issue with depending on PublishingContext.default, currently tests are pass for this branch, and SiteTests/publishingWithInvalidLastModifiedDate that should've fail (as the fix is within #438) gave a false positive result because PublishingContext.default got initialised with some other unit test.

@erikbasargin erikbasargin changed the title Fix "Ignite build" crashes when Markdown content contains invalid lastModified date Increased stability of SiteTests Jan 31, 2025
@JPToroDev JPToroDev merged commit cc9430c into twostraws:main Feb 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants