feat(network): refactor local state #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test fixture is also included.
```diff
diff --git a/pallas-network/tests/protocols.rs b/pallas-network/tests/protocols.rs
index 5812f88838ed..b625632f0f15 100644
--- a/pallas-network/tests/protocols.rs
+++ b/pallas-network/tests/protocols.rs
@@ -290,7 +290,6 @@ pub async fn local_state_query_server_and_client_happy_path() {
.unwrap();
// server receives range from client, sends blocks
-
let clientacquirerequest(maybe_point) =
server_sq.recv_while_idle().await.unwrap().unwrap();
@@ -322,7 +321,6 @@ pub async fn local_state_query_server_and_client_happy_path() {
.unwrap();
// server receives release from the client
-
match server_sq.recv_while_acquired().await.unwrap() {
clientqueryrequest::release => (),
x => panic!("unexpected message from client: {x:?}"),
@@ -360,7 +358,6 @@ pub async fn local_state_query_server_and_client_happy_path() {
assert_eq!(*server_sq.state(), localstate::state::acquired);
// server receives reaquire from the client
-
let maybe_point = match server_sq.recv_while_acquired().await.unwrap() {
clientqueryrequest::reacquire(p) => p,
x => panic!("unexpected message from client: {x:?}"),
@@ -372,7 +369,6 @@ pub async fn local_state_query_server_and_client_happy_path() {
server_sq.send_acquired().await.unwrap();
// server receives release from the client
-
match server_sq.recv_while_acquired().await.unwrap() {
clientqueryrequest::release => (),
x => panic!("unexpected message from client: {x:?}"),
```
currently supporting only non params local state queries
```diff
diff --git a/pallas-network/src/miniprotocols/localstate/queries.rs b/pallas-network/src/miniprotocols/localstate/queries.rs
index dabc73e646d0..71921c1672c7 100644
--- a/pallas-network/src/miniprotocols/localstate/queries.rs
+++ b/pallas-network/src/miniprotocols/localstate/queries.rs
@@ -42,7 +42,7 @@ impl encode<()> for blockquery {
e.u16(0)?;
e.array(2)?;
/*
- todo: i think this is era or something? first fetch era with
+ todo: think this is era or something? first fetch era with
[3, [0, [2, [1]]]], then use it here?
*/
e.u16(5)?;
```
renames the variants of the `blockqueryresponse` enum in the `queries.rs` file of the `localstate` miniprotocol. the following changes were made: - `getledgertip` is now `ledgertip` - `stakepools` is now `currentpparams` - `getcurrentpparams` is now `proposedpparamsupdates` - `getproposedpparamsupdates` is now `stakedistribution` - `getstakedistribution` is now `genesisconfig` - `getgenesisconfig` is now `debugchaindepstate` - `getrewardprovenance` is now `rewardprovenance` - `getstakepools` is now `stakepools` - `getrewardinfopools` is now `rewardinfopools`
this has been an attempt to map the server requests into our responses. tests must be updated.
we added the struct. maybe we should adapt to use it as turbofish
- changed the argument of the `do_localstate_query` function from `localstate::queries::request` to `request` - updated the function call in `main` to use `request` instead of `localstate::queries::request` - removed unnecessary impls for `epochno`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.