feat(network): Local Tx Submission errors #598
Merged
+775
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 12, 2025
scarmuega
approved these changes
Feb 13, 2025
|
For anyone interested, we have a full working implementation of all the tx submission errors in this fork: https://github.com/blockfrost/pallas/tree/feat/blockfrost This fork also generates identical error messages to the Haskell native cardano submit API. We plan to open a PR once we do a bit of refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decodes the
RejectReasonafter a failed local Tx submission by structuring into two variants:(Era, Vec<TxError>)pair.The
TxErrortype corresponds to the Conway era ledger transaction errors. Its only analyzed variant is that of ConwayUtxowPredFailure for which, in turn, 6 variants have been implemented along with their deeper structure.For each error having variants not yet analyzed, a temporary "raw" variant was added to hold the CBOR information.
Unit-tests using an up-to-date preprod node response were added to
codec.rs. For instance, I had to implement theSMaybeoption type with the codec corresponding to (S)Maybetype of the Cardano node, required for many types (different to default one forOption<T>.This PR properly subsumes #562, #584, #585, #588, and #593, which are to be closed.