Skip to content

Commit

Permalink
Lint charts using next-version too
Browse files Browse the repository at this point in the history
  • Loading branch information
Juan Manuel "Kang" Perez authored and kang-makes committed Jun 17, 2024
1 parent 97a3302 commit 185a087
Showing 1 changed file with 21 additions and 14 deletions.
35 changes: 21 additions & 14 deletions .github/workflows/lint-and-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,6 @@ name: Lint and test PR
on: pull_request

jobs:
chart-lint:
name: Lint Helm charts
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Install helm/chart-testing
uses: helm/[email protected]
- name: Lint charts
run: ct --config .github/ct.yaml lint --all

chart-unittest:
name: Unit test Helm charts
runs-on: ubuntu-latest
Expand Down Expand Up @@ -75,6 +62,26 @@ jobs:
id: version
uses: newrelic/release-toolkit/next-version@v1

chart-lint:
name: Lint Helm charts
runs-on: ubuntu-latest
needs:
# Lint charts using the next version.
- changelog-checks
steps:
- name: Checkout code
uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Install helm/chart-testing
uses: helm/[email protected]
# Change version of the Helm chart to the next one so test upgrade path
- name: Set chart version to rt's next-version
run: |
yq -i '.version = "${{ needs.changelog-checks.outputs.next-version }}"' charts/stateless-dns/Chart.yaml
- name: Lint charts
run: ct --config .github/ct.yaml lint --all

chart-install:
name: Installation test for Helm charts
runs-on: ubuntu-latest
Expand Down Expand Up @@ -102,7 +109,7 @@ jobs:
# Change version of the Helm chart to the next one so test upgrade path
- name: Set chart version to rt's next-version
run: |
yq -i '.version = ${{ needs.changelog-checks.outputs.next-version }}' charts/stateless-dns/Chart.yaml
yq -i '.version = "${{ needs.changelog-checks.outputs.next-version }}"' charts/stateless-dns/Chart.yaml
# Test chart installation
- name: Install helm/chart-testing
Expand Down

0 comments on commit 185a087

Please sign in to comment.