Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow defining ipFamilyPolicy for services #95

Merged
merged 1 commit into from
Aug 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Unreleased

### Enhancement
- Allow specifying `ipFamilyPolicy` on all services.

## v0.5.1 - 2024-08-09

### ⛓️ Dependencies
Expand Down
12 changes: 12 additions & 0 deletions charts/stateless-dns/templates/services.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ metadata:
{{- include "stateless-dns.labels" . | nindent 4 }}
spec:
type: {{ .Values.service.dnsUdp.type }}
{{- with .Values.service.dnsUdp.ipFamilyPolicy }}
ipFamilyPolicy: {{ . | quote }}
{{- end }}
ports:
- port: {{ .Values.service.dnsUdp.port }}
targetPort: dns-udp
Expand All @@ -37,6 +40,9 @@ metadata:
{{- include "stateless-dns.labels" . | nindent 4 }}
spec:
type: {{ .Values.service.dnsTcp.type }}
{{- with .Values.service.dnsTcp.ipFamilyPolicy }}
ipFamilyPolicy: {{ . | quote }}
{{- end }}
ports:
- port: {{ .Values.service.dnsTcp.port }}
targetPort: dns-tcp
Expand All @@ -61,6 +67,9 @@ metadata:
{{- include "stateless-dns.labels" . | nindent 4 }}
spec:
type: {{ .Values.service.api.type }}
{{- with .Values.service.api.ipFamilyPolicy }}
ipFamilyPolicy: {{ . | quote }}
{{- end }}
ports:
- port: {{ .Values.service.api.port }}
targetPort: http
Expand All @@ -85,6 +94,9 @@ metadata:
{{- include "stateless-dns.labels" . | nindent 4 }}
spec:
type: {{ .Values.service.externalDNSMetrics.type }}
{{- with .Values.service.externalDNSMetrics.ipFamilyPolicy }}
ipFamilyPolicy: {{ . | quote }}
{{- end }}
ports:
- port: {{ .Values.service.externalDNSMetrics.port }}
targetPort: metrics-http
Expand Down
5 changes: 5 additions & 0 deletions charts/stateless-dns/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,23 +32,28 @@ service:
api:
enabled: true # Specifies whether a service that points to the http port of pdns http API should be created. It is separated from the other services so the user can select service type freely from the others needed.
type: ClusterIP # Service type.
# ipFamilyPolicy can be defined as below. If ommited, it will not be rendered in yaml.
# ipFamilyPolicy: SingleStack
port: 80 # Service port.
annotations: {} # Annotations to add to the service.

dnsUdp:
enabled: true # Specifies whether a service that points to the UDP port of pdns should be created. It is separated from TCP DNS port because of limitations of Kubernetes. You cannot create a service with type LoadBalancer that exposes UDP and TCP ports at the same time. Two services should workaround this limitation.
# ipFamilyPolicy: SingleStack
type: ClusterIP # Service type.
port: 53 # Service port.
annotations: {} # Annotations to add to the service.

dnsTcp:
enabled: true # Specifies whether a service that points to the TCP port of pdns should be created. It is separated from UDP DNS port because of limitations of Kubernetes. You cannot create a service with type LoadBalancer that exposes UDP and TCP ports at the same time. Two services should workaround this limitation.
# ipFamilyPolicy: SingleStack
type: ClusterIP # Service type.
port: 53 # Service port.
annotations: {} # Annotations to add to the service.

externalDNSMetrics:
enabled: true # Specifies whether a service that points to the http port of external-dns prometheus metrics.
# ipFamilyPolicy: SingleStack
type: ClusterIP # Service type.
port: 80 # Service port.
annotations: {} # Annotations to add to the service.
Expand Down
Loading