-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support of http chunks and change EventSource implementation #3
base: master
Are you sure you want to change the base?
Conversation
…ors, making it proxifiable.
Better handling of resource cleanup.
Ensure empty lines are not ignored when data is available.
Stick to spec and remove connect method.
Thanks for the pull request! I'll try to review the code within the next day or two and merge if all looks well. |
@motwingh I originally threw this project out there without many modifications to a previous library. I noticed that a lot of these commits have a bunch of style changes, as well as code changes. Would you mind if I cleaned up the project a bit, then asked you to submit a new request for the change? I also want to remove the Netty dependency soon in favor of OkHttp, as well as potentially use rxAndroid to improve callback threading, etc. These changes will probably take a bit of time though. I've noticed that string resources, appCompat lib, and other unnecessary files were also added in some of the commits. |
Hi, |
The repo is in a more stable state now. You can submit the new pull request whenever you get the chance. |
When server is configured to allow chunked transfer encoding with header
Transfer-Encoding: chunked
If response is big enough, it can possibly be sent as HTTP chunks. The current implementation does not handle chunks.
This is a proposal of a chunk handling implementation.
We also changed the EventSource and AsyncEventSourceHandler.
Last thing we used AndroidStudio 2.2 to edit the project and added corresponding configuration files.
Please review for a merge .