-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify python interpreter when installing pip dependencies for CI #656
base: development
Are you sure you want to change the base?
Specify python interpreter when installing pip dependencies for CI #656
Conversation
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
""" | ||
rctx.file("WORKSPACE", "workspace(name = \"%s\")"%rctx.attr.name) | ||
rctx.file("BUILD.bazel", content=build_file_content, executable=False) | ||
rctx.symlink(resolved_interpreter_label, "python") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this Windows-friendly?
.circleci/config.yml
Outdated
apt update -y && apt install -y software-properties-common | ||
add-apt-repository -y ppa:deadsnakes/ppa | ||
apt update -y && apt install -y python3.9 python3.9-distutils python3-pip software-properties-common | ||
python3.9 -m pip install -U cffi | ||
python3.10 -m pip install -U cffi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we now remove all of these?
d6f26eb
to
d90c666
Compare
Usage and product changes
We now specify the python interpreter when installing pip dependencies for CI. This allows us to ensure the dependencies are installed for the specified toolchain.
Implementation
Introduce a
python_interpreter_symlink
repository which resolves toolchain based on information fromrepository_context.os
. The symlink for the right version can then be passed topip_parse
as thepython_interpreter_target
argument.