Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CPython 3.13 #705

Open
wants to merge 1 commit into
base: 3.0
Choose a base branch
from
Open

Support CPython 3.13 #705

wants to merge 1 commit into from

Conversation

sanmai-NL
Copy link

@sanmai-NL sanmai-NL commented Nov 1, 2024

Usage and product changes

Support CPython 3.13, which has been released on 7 October.

Implementation

  • Change the Bazel file.
  • ...?

@typedb-bot
Copy link
Member

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@farost
Copy link
Member

farost commented Nov 7, 2024

@sanmai-NL Hi, thank you for your contribution!

We need to update our core Bazel dependencies first, but we're already in the process of its verification and come back a bit later.

Just in case, do you need the driver for Python 3.13 to try 3.0-alpha or to work on production stuff? The PR is directed into 3.0 branch, but we can consider a special release of a stable 2.x version from development if you really need it.

@farost farost self-requested a review November 7, 2024 16:12
@farost farost self-assigned this Nov 7, 2024
@sanmai-NL
Copy link
Author

sanmai-NL commented Nov 7, 2024

@sanmai-NL Hi, thank you for your contribution!

We need to update our core Bazel dependencies first, but we're already in the process of its verification and come back a bit later.

Just in case, do you need the driver for Python 3.13 to try 3.0-alpha or to work on production stuff? The PR is directed into 3.0 branch, but we can consider a special release of a stable 2.x version from development if you really need it.

We actually use TypeDB 2.x for a product where upgrading to Python 3.13 is desired and held back by this dependency, plus one other small dependency.

@farost farost changed the base branch from 3.0 to development November 8, 2024 09:08
@farost farost changed the base branch from development to 3.0 November 8, 2024 09:09
@farost
Copy link
Member

farost commented Nov 8, 2024

@sanmai-NL Hi, thank you for your contribution!
We actually use TypeDB 2.x for a product where upgrading to Python 3.13 is desired

That's nice! Unfortunately, the timing is a bit off for us at the moment. We are in the middle of finishing up version 3.0, and making the dependencies update required for the TypeDB 2.x Python 3.13 build is quite unsafe.

What features of the driver do you use and how critical is the update for you this month? I suggest waiting until we release the stable version of 3.0 (in the coming months) with all the needed driver versions and API updates. You'd need to migrate your database using our tools and explore the updated syntax and constraints. Another noticeable thing that could require some refactoring from you is the elimination of Concept API (you'll have a single entry point of retrieving and updating your concepts through transaction.query("...")). Of course, we'll always be happy to support your migration once 3.0 is live. How does it sound to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants