Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Align instance #643

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add Align instance #643

wants to merge 4 commits into from

Conversation

johnynek
Copy link
Collaborator

Thank you for contributing to cats-parse!

This is a kind reminder to run sbt prePR and commit the changed files, if any, before submitting.

@johnynek
Copy link
Collaborator Author

Align isn't in scala 2.11 so we have to drop support for that first. I guess since others are talking about dropping 2.12, dropping 2.11 seems like it should be fine.

Copy link
Collaborator

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@johnynek I guess a release with 2.11 dropped needs to go out first right?

@johnynek
Copy link
Collaborator Author

@regadas since the last release at the end of the year, there haven't been any changes except build dependencies:

https://github.com/typelevel/cats-parse/releases

I already removed 2.11 in a previous PR to get sbt-typelevel to work: #644

So I think we can just merge this as is...

So far it would be the only user facing change (other than no more 2.11, but if you want 2.11, just use the last published version I guess).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants