feat: casting empty numberstring to null #1390
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the MVC web service, when receiving user input as object from the controller through form submit, each fields should be casted from string to suitable type.
and class-transformer returns 0 when converting empty string to number.
so, IsNotEmpty of class-validator doesn't work for number field because the number field user not input will be initialized to 0.
If class-transformer returns null when converting empty characters to numbers, then IsNotEmpty can be used for number fields as well.
Checklist
Update index.md
)develop
)npm run prettier:check
passesnpm run lint:check
passes