Merge pull request #1464 from pgwillia/1463_vcr_for_external_services

Use vcr for external services
ualbertalib · Jan 17, 2019 · d9f807e · d9f807e
2 parents eade1cd + 486fefc
commit d9f807e
Show file tree

Hide file tree

Showing 9 changed files with 580 additions and 10 deletions.
diff --git a/Gemfile b/Gemfile
@@ -81,6 +81,9 @@ group :test do
 
   gem 'selenium-webdriver'
 
+  gem 'vcr', require: false
+  gem 'webmock', require: false
+
   # Easy installation and use of chromedriver to run system tests with Chrome
   gem 'chromedriver-helper'
 end
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -124,6 +124,8 @@ GEM
       rails-i18n (>= 4.0.0)
       sass-rails (>= 4.0.3)
     concurrent-ruby (1.1.4)
+    crack (0.4.3)
+      safe_yaml (~> 1.0.0)
     crass (1.0.4)
     daemons (1.3.1)
     debug_inspector (0.0.3)
@@ -158,6 +160,7 @@ GEM
       haml (>= 4.0.6, < 6.0)
       html2haml (>= 1.0.1)
       railties (>= 4.0.1)
+    hashdiff (0.3.8)
     html2haml (2.2.0)
       erubis (~> 2.7.0)
       haml (>= 4.0, < 6)
@@ -321,6 +324,7 @@ GEM
     ruby_parser (3.12.0)
       sexp_processor (~> 4.9)
     rubyzip (1.2.2)
+    safe_yaml (1.0.4)
     sass (3.7.2)
       sass-listen (~> 4.0.0)
     sass-listen (4.0.0)
@@ -380,8 +384,13 @@ GEM
       unf_ext
     unf_ext (0.0.7.5)
     unicode-display_width (1.4.0)
+    vcr (4.0.0)
     warden (1.2.7)
       rack (>= 1.0)
+    webmock (3.5.1)
+      addressable (>= 2.3.6)
+      crack (>= 0.3.2)
+      hashdiff
     xml-simple (1.1.5)
     xpath (2.1.0)
       nokogiri (~> 1.3)
@@ -433,6 +442,8 @@ DEPENDENCIES
   spring
   turbolinks (= 5.2.0)
   uglifier (>= 1.3.0)
+  vcr
+  webmock
   xpath (= 2.1.0)
 
 BUNDLED WITH

diff --git a/fixtures/vcr_cassettes/holdings_with_links.yml b/fixtures/vcr_cassettes/holdings_with_links.yml
diff --git a/fixtures/vcr_cassettes/item_result.yml b/fixtures/vcr_cassettes/item_result.yml
diff --git a/spec/blacklight_helper.rb b/spec/blacklight_helper.rb
@@ -6,6 +6,8 @@
 require 'active_support/inflector'
 require 'capybara/rspec'
 require 'capybara/rails'
+require 'vcr'
+require 'webmock/rspec'
 require_relative '../lib/ingest/dublin_core_om'
 require_relative '../lib/ingest/peel_mods_om'
 require_relative '../lib/ingest/databases'

diff --git a/spec/features/catalog_search_spec.rb b/spec/features/catalog_search_spec.rb
@@ -11,7 +11,9 @@
   end
 
   scenario 'User visits an item result' do
-    visit 'catalog/1001523'
-    expect(page).to have_text('Shakespeare: a historical and critical study with annotated texts of twenty-one plays')
+    VCR.use_cassette('item_result') do
+      visit 'catalog/1001523'
+      expect(page).to have_text('Shakespeare: a historical and critical study with annotated texts of twenty-one plays')
+    end
   end
 end