[Discovery] More complete feature test suite

[pgwillia]

Is your feature request related to a problem? Please describe.
I'm always frustrated when I try to make changes, or do updates and I'm not confident that I've checked every possible regression, or even know what all the features are to test.

Describe the solution you'd like

Results

• Shield/logo to represent UofA holdings
• Google book jackets
• Metadata for symphony holdings includes Author, format, publication year, copies owned by
• Metadata for ejournals and databases is more limited.
• By default 25 results are displayed.
• Many more facets

Record View

• Go to bookmarks (Address key length issue with refworks/bookmarks after ruby upgrade #1562)
• Send a correction ([Discovery] Add feature tests for sending a correction #1727)
• View search history ([Discovery] Add feature tests for search history #1725)
• Text me (Canadian SMS) / email me ([Discovery] Feature tests for text/email me features #1722)
• Journal records contain proper metadata ([Discovery] Journal records contain proper metadata #1704)
• Chained subject linking ([Discovery] Feature tests for chained subject linking #1708)
• Author link on record view page search for the author ([Discovery] Feature tests for item author links #1710)
• Content presented in the holding table is proper ([Discovery] Feature tests for item holding table #1712)

Databases and ejournals Record View

• Usage rights in the holding table ([Discovery] Feature tests for item holding table #1712)
• Coverage information (blocked by [Discovery] [Spike] Coverage Information/Title for SFX Data - SFX - holdings are being deduplicated  #1473)
• A tiny link to ILL ([Discovery] Feature tests for link to ill #1740)

Search Result

• Create feature tests for the search result page: Create feature tests for the search result page #1600

Logging (tests will be implemented in #423)

• errors in logs
• deprecations in logs

Fix blacklight/spec/rails helper #1464 (comment)

Many of these customizations are identified in this report: https://docs.google.com/document/d/1VTeu4ZYfLhbLWsznRqFBU0qccQhD17J83tW6LDQu7OY/

Describe alternatives you've considered
Continue to test manually and have low confidence when deploying.

[seanluyk]

@pgwillia this is really fantastic, I fully support this work given our current deployment issues

[murny]

NOTE: as part of this ticket we need to get off ingesting tons of objects into solr every time you run the tests? You don't need thousands of objects to test the code.

As a result this makes the tests take far longer then they should be (rspec itself takes no time at all to run (since we only have 75 tests), but this ingestion process takes 3 times longer then the actual rspec process). And also this makes debugging travis difficult because of the spam the ingestion creates and as a result you can't see anything in travis about the actual tests:

[weiweishi]

We will move adding test for the logging to #423. Remaining work:

• a tiny link to ILL. ([Discovery] Feature tests for link to ill #1740)

Test for coverage information is blocked by #1473