This repository has been archived by the owner on Dec 22, 2022. It is now read-only.
Use vcr for external services #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing is failing because the record we use to test the electronic holdings no longer has any holdings.
|
@seanluyk do you know if there is anything in the ws terms of service that prevents us from recording/storing |
murny
reviewed
Jan 17, 2019
| @@ -6,6 +6,8 @@ | |||
| require 'active_support/inflector' | |||
| require 'capybara/rspec' | |||
| require 'capybara/rails' | |||
| require 'vcr' | |||
There was a problem hiding this comment.
No idea why we have this file?
The point of spec_helper vs rails_helper is spec_helper is suppose to be a lightweight version that doesn't need or depend on all the rails stuff. But here we bloat everything inside this blacklight_helper, then include it in spec_helper (where spec_helper shouldn't need all this stuff like capybara/rails/etc)...which is then included in rails_helper.
No change required here. More so just documenting this and linking this comment to this our testing refactor issue so we can tackle this later
20 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1463
Testing is failing because the record we use to test the electronic holdings no longer has any holdings. Falsified the marc xml to use a more current id of this item. Added vcr to record use of external services.