-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a flag to control generation of the invocation comment #105
Conversation
The invocation comment stores the complete details of all provided arguments, which may include paths to files. These aren't always consistent, which results in unwanted changes in the generated files (especially for CI checking for unexpected changes...). Since the invocation isn't always useful, provide a flag to control whether the comment is generated. To preserve current behaviour this defaults to true (enabled). Signed-off-by: Stephen Kitt <[email protected]>
|
@skitt - Can you sign the CLA so that this gets merged? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will be merged once author signs CLA.
I’m just waiting for our legal department to check it. |
@skitt any progress on the CLA? We are staying at v0.2.0 until there is a new release with this fix. |
It’s still pending, sorry... |
@JacobOaks I've created an alternate PR (#153) against the latest main (no conflicts) and have signed the CLA. This should allow for mockgen to be released with this issue fixed for good. FYI, I have contributed to the project before the ownership transfer. |
That’s fine @JacobOaks, thanks @sodul for proposing an alternate PR! |
The invocation comment stores the complete details of all provided arguments, which may include paths to files. These aren't always consistent, which results in unwanted changes in the generated files (especially for CI checking for unexpected changes...).
Since the invocation isn't always useful, provide a flag to control whether the comment is generated. To preserve current behaviour this defaults to true (enabled).
Fixes #104.