Added dependabot #54
Merged
Added dependabot #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Neo2308
commented
Aug 8, 2023
Neo2308
commented
- Added dependabot to keep go dependencies & actions updated.
|
|
Neo2308
force-pushed
the
feature/master/add-dependabot-config
branch
from
9773417
to
78c55e7
Compare
|
@sywhang could you review? |
|
Hey @Neo2308 - sorry for the long delay for review. This looks good to me, but can you also add a gomod entry for "/tools" (i.e. https://github.com/uber-go/mock/tree/main/tools) |
* Added dependabot to keep go dependencies & actions updated.
Added internal folders to dependabot config
Added /tools to dependabot config
Neo2308
force-pushed
the
feature/master/add-dependabot-config
branch
from
85876e5
to
fbdb9a4
Compare
|
@JacobOaks done :) |
abhinav
reviewed
Mar 4, 2024
Comment on lines
+3
to
+7
| - package-ecosystem: "gomod" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "daily" | ||
| open-pull-requests-limit: 5 |
There was a problem hiding this comment.
Hey @Neo2308 @JacobOaks I'd like to suggest reconsidering this change.
Adding dependabot for a library means that all users of the library must upgrade to latest version of all transitive dependencies all the time.
Please consider dropping this specific section from the dependabot so that the library's dependencies remain specific to only what it needs when it needs it. Everything else can remain as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.