Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --sandbox_debug bazel arg #161

Merged
merged 3 commits into from
Sep 20, 2024
+12 −24
Merged

Remove --sandbox_debug bazel arg #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e3ca72
Remove --sandbox_debug bazel arg
chrisdothtml Sep 19, 2024
b00bbe7
bump
chrisdothtml Sep 19, 2024
25efbba
bump
chrisdothtml Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "jazelle",
"version": "0.0.0-standalone.95",
"version": "0.0.0-standalone.96",
"main": "index.js",
"bin": {
"barn": "bin/bootstrap.sh",
Expand Down Expand Up @@ -29,5 +29,9 @@
"preupdate-vendor": "mv vendor/.gitignore .vendor-gitignore",
"postupdate-vendor": "mv .vendor-gitignore vendor/.gitignore",
"update-vendor": "yarn install --prod --flat --frozen-lockfile --modules-folder=vendor"
},
"volta": {
"node": "16.15.0",
"yarn": "1.19.1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are the current versions used in CI and adding it here makes dev easier for anyone who uses volta

}
}
30 changes: 7 additions & 23 deletions utils/bazel-commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,11 @@ const build /*: Build */ = async ({
stdio = 'inherit',
}) => {
cwd = relative(root, cwd);
await spawnOrExit(
bazel,
[...startupFlags, 'build', `//${cwd}:${name}`, '--sandbox_debug'],
{
stdio,
env: {...process.env},
cwd: root,
}
);
await spawnOrExit(bazel, [...startupFlags, 'build', `//${cwd}:${name}`], {
stdio,
env: {...process.env},
cwd: root,
});
};

/*::
Expand All @@ -59,13 +55,7 @@ const test /*: Test */ = async ({
const testParams = args.map(arg => `--test_arg=${arg}`);
await spawnOrExit(
bazel,
[
...startupFlags,
'run',
`//${cwd}:${name}`,
'--sandbox_debug',
...testParams,
],
[...startupFlags, 'run', `//${cwd}:${name}`, ...testParams],
{
stdio,
env: {...process.env},
Expand Down Expand Up @@ -95,13 +85,7 @@ const run /*: Run */ = async ({
const runParams = args.length > 0 ? ['--', ...args] : [];
await spawnOrExit(
bazel,
[
...startupFlags,
'run',
`//${cwd}:${name}`,
'--sandbox_debug',
...runParams,
],
[...startupFlags, 'run', `//${cwd}:${name}`, ...runParams],
{
stdio,
env: {...process.env},
Expand Down
Loading