Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build index readiness endpoint and client #377

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

Anton-Kalpakchiev
Copy link
Collaborator

@Anton-Kalpakchiev Anton-Kalpakchiev commented Nov 13, 2024

As described in #371, all services should implement a "readiness" endpoint, which checks whether the service is ready to serve traffic, i.e. whether it can reach all of its dependencies.

  • Add readiness endpoint for build index, which checks whether all its backends are reachable and the origin's readiness.
  • Add a client for build-index's readiness endpoint. The client will be used by agent -- agent's readiness endpoint will check build index's readiness, as build index is a dependency for agent.
    Stacked on top of Add origin readiness endpoint #373

build-index/tagclient/client.go Show resolved Hide resolved
Copy link
Collaborator

@gkeesh7 gkeesh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments otherwise LGTM

Base automatically changed from origin-client to master November 15, 2024 12:17
@Anton-Kalpakchiev Anton-Kalpakchiev merged commit 735046c into master Nov 15, 2024
5 checks passed
@Anton-Kalpakchiev Anton-Kalpakchiev deleted the build-index-is-ready branch November 15, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants