Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to use startActivity with flags instead of startActivityForResult #262

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

lalwani
Copy link
Collaborator

@lalwani lalwani commented Dec 17, 2024

Previously we were resulting on startActivityForResult to invoke an Uber app for sso. This results in subpar UX and is buggy because it creates a new instance of the Uber app's activity which shows on top of the third party's app stack. So, we are changing the implementation a little big and returning the result via redirect uri that was passed using the sso_config.json configuration from the third party app.
The authCode will be passed in the fragment of the redirect uri as mentioned in this RFC
The authCode will only be returned if all other config information that was setup on the Uber developer dash for the third party app matches with the authorization request.
This does not change the integration point of the calling app but is a change inside the sdk itself.

Also, adding calling app package to the intent to have a sanity validation on the Uber app for redirect uri match

@lalwani lalwani requested a review from psteiger December 17, 2024 18:55
@lalwani lalwani merged commit e664878 into main Dec 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants