-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test deprecation warning #518
Open
kzqureshi
wants to merge
6
commits into
master
Choose a base branch
from
test_DeprecationWarning
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0baab3c
changed np.product to np.prod in mesh.dV to avoid DeprecationWarning
kzqureshi d37672b
ensuring scalar from integrate function
kzqureshi 4c3ffd0
correction from field.plane to filed.sel
kzqureshi ecb696c
config file for ignoring warnings
kzqureshi d27e50f
changed point_columns dependency from 3 to n dims
kzqureshi a1f3e9f
Merge branch 'master' into test_DeprecationWarning
kzqureshi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -273,9 +273,17 @@ def topological_charge(field, /, method="continuous", absolute=False): | |
|
||
q = topological_charge_density(field, method=method) | ||
if absolute: | ||
return float(abs(q).integrate()) | ||
result = abs(q).integrate() | ||
if isinstance(result, np.ndarray) and result.size == 1: | ||
result = result.item() | ||
assert np.isscalar(result), "Expected a scalar result from integration" | ||
return float(result) | ||
Comment on lines
+276
to
+280
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What are these conversions required for? |
||
else: | ||
return float(q.integrate()) | ||
result = q.integrate() | ||
if isinstance(result, np.ndarray) and result.size == 1: | ||
result = result.item() | ||
assert np.isscalar(result), "Expected a scalar result from integration" | ||
return float(result) | ||
|
||
|
||
def emergent_magnetic_field(field): | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
[pytest] | ||
python_files = test_*.py | ||
python_functions = test_* | ||
filterwarnings = | ||
ignore::DeprecationWarning:traitlets.*: | ||
#ignore:Automatic coloring is only supported for 3d fields.*:UserWarning | ||
ignore:The truth value of an empty array is ambiguous.*:DeprecationWarning | ||
ignore:invalid value encountered in divide:RuntimeWarning | ||
ignore:`ipykernel.pylab.backend_inline` is deprecated.*:DeprecationWarning | ||
Comment on lines
+1
to
+9
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is part of #524; please remove from this MR.