Implement singleton logic #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Craftplacer
commented
Nov 4, 2024
Jupi007
reviewed
Nov 4, 2024
Craftplacer
force-pushed
the
managed-disposal-and-singleton
branch
from
b298abd
to
66f9f2a
Compare
Jupi007
requested changes
Nov 4, 2024
Craftplacer
force-pushed
the
managed-disposal-and-singleton
branch
from
ef3617d
to
c785668
Compare
|
Our test runner should install SANE I think... |
|
You're right, fixed in #25 |
Craftplacer
force-pushed
the
managed-disposal-and-singleton
branch
from
c785668
to
4482fc4
Compare
Jupi007
reviewed
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exiting marks the current global instance as disposed and removes the singleton, so the application can only ever have one valid and initiated instance.