Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use logging package #26

Merged
merged 5 commits into from
Nov 6, 2024
Merged

Use logging package #26

merged 5 commits into from
Nov 6, 2024

Conversation

Craftplacer
Copy link
Collaborator

@Craftplacer Craftplacer commented Nov 4, 2024 •
edited
Loading

Resolves #7

Jupi007
Jupi007 requested changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove avoid_print: ignore in analysis_options.yaml.

packages/sane/lib/src/sane_dev.dart Outdated Show resolved Hide resolved
@Feichtmeier
Copy link
Member

just a question: does this package always print or only if(kDebugMode) ?

@Jupi007
Copy link
Collaborator

Jupi007 commented Nov 4, 2024

@Feichtmeier The goal is to log messages, then leave the app developer the responsibility to print them (see the example app).

@Jupi007 Jupi007 merged commit 03edaef into ubuntu-flutter-community:main Nov 6, 2024
3 checks passed
@Jupi007
Copy link
Collaborator

Jupi007 commented Nov 6, 2024

Thanks @Craftplacer
I'll push my isolate patch tomorrow.

@Jupi007 Jupi007 mentioned this pull request Nov 7, 2024
Merged
@Craftplacer Craftplacer deleted the logging branch November 10, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jupi007 Jupi007 Jupi007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use proper logging framework
3 participants
@Craftplacer @Feichtmeier @Jupi007