Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't stage libigdgmm-dev, it's not required and doesn't exist on armhf #222

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

seb128
Copy link
Contributor

@seb128 seb128 commented Jun 19, 2024

It was added as part of !221 and it breaking arm builds since the package is intel specific. Afaik the sdk was building before so it shouldn't be really required?

@seb128 seb128 requested a review from jssotomdz June 19, 2024 08:18
@seb128
Copy link
Contributor Author

seb128 commented Jun 19, 2024

As the CI is showing that needs to be fixed, I'm going to rework it

@jssotomdz
Copy link
Contributor

jssotomdz commented Jun 19, 2024

Just a thought, I added the ci for amd64 and now an issue appears on a different architecture. Anything we can do ci-wise to test other archs?

@seb128
Copy link
Contributor Author

seb128 commented Jun 19, 2024

Just a thought, I added the ci for amd64 and now an issue appears on a different architecture. Anything we can do ci-wise to test other archs?

I'm unsure, I think github CI doesn't provide other architectures...

@seb128 seb128 merged commit c46fa51 into ubuntu:gnome-46-2404-sdk Jun 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants