Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd/insights): Udeng 5696 initial client core cli #2

Merged
merged 22 commits into from
Jan 13, 2025
Merged

feat(cmd/insights): Udeng 5696 initial client core cli #2

merged 22 commits into from
Jan 13, 2025

Conversation

hk21702
Copy link
Collaborator

@hk21702 hk21702 commented Dec 20, 2024 •
edited
Loading

Initial implementation of the CLI for the main insights client.

  • Collect
  • Upload
  • Consent

Dependent on #1

UDENG-5696

@hk21702 hk21702 added the enhancement New feature or request label Dec 20, 2024
@hk21702 hk21702 self-assigned this Dec 20, 2024
@hk21702 hk21702 force-pushed the UDENG-5696-initial-client-core-cli branch from cf5cd62 to 2c43b75 Compare January 8, 2025 17:36
@hk21702 hk21702 mentioned this pull request Jan 10, 2025
Merged
@hk21702 hk21702 changed the title refactor(cmd/insights): Udeng 5696 initial client core cli feat(cmd/insights): Udeng 5696 initial client core cli Jan 10, 2025
@hk21702 hk21702 force-pushed the UDENG-5696-initial-client-core-cli branch from 19b181b to 3f43a56 Compare January 10, 2025 17:53
@hk21702 hk21702 force-pushed the UDENG-5696-initial-client-core-cli branch from 3f43a56 to cb7791b Compare January 10, 2025 17:56
@hk21702 hk21702 requested a review from Sploder12 January 10, 2025 18:23
@hk21702 hk21702 marked this pull request as ready for review January 10, 2025 18:23
@hk21702
Copy link
Collaborator Author

hk21702 commented Jan 10, 2025

The contents here will have to be revised at some point and refactored, but this acts as a starting point to branch off of.

@hk21702 hk21702 requested a review from sharder996 January 13, 2025 15:17
Sploder12
Sploder12 requested changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@Sploder12 Sploder12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, just some issues in constants.

cmd/insights/commands/consent.go Show resolved Hide resolved
internal/constants/constants.go Outdated Show resolved Hide resolved
internal/constants/constants.go Outdated Show resolved Hide resolved
internal/constants/constants.go Outdated Show resolved Hide resolved
@hk21702 hk21702 force-pushed the UDENG-5696-initial-client-core-cli branch from ede5882 to 5561fc8 Compare January 13, 2025 18:04
@hk21702 hk21702 requested a review from Sploder12 January 13, 2025 18:24
@hk21702 hk21702 force-pushed the UDENG-5696-initial-client-core-cli branch from 07a2aa4 to 4c96b5b Compare January 13, 2025 18:34
Sploder12
Sploder12 approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@Sploder12 Sploder12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hk21702 hk21702 merged commit 7aa873b into main Jan 13, 2025
1 check passed
@hk21702 hk21702 deleted the UDENG-5696-initial-client-core-cli branch January 13, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sploder12 Sploder12 Sploder12 approved these changes

@sharder996 sharder996 Awaiting requested review from sharder996

Assignees

@hk21702 hk21702

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hk21702 @Sploder12