-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(internal/consent): UDENG-5705 ubuntu insights consent manager #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Helper functions to setup consent manager test env - RLock and Lock support - Get all sources - Get specific sources - Go routined reads
hk21702
changed the title
enhancement(internal/consent): UDENG-5705 ubuntu insights consent manager
feat(internal/consent): UDENG-5705 ubuntu insights consent manager
Jan 10, 2025
…gument behavior. Disable default cobra error printing. Update CLI flag descriptions
- Respect read and write locks - Create new files if the target source does not exist - Functionality for both source specific files, and the global consent file
hk21702
force-pushed
the
UDENG-5705-Ubuntu-Insights-Consent-Manager
branch
from
January 10, 2025 19:33
5c963b0
to
f584a4f
Compare
…ntu-Insights-Consent-Manager
…ages in collect command
…ntu-Insights-Consent-Manager
…ntu-Insights-Consent-Manager
hk21702
force-pushed
the
UDENG-5705-Ubuntu-Insights-Consent-Manager
branch
2 times, most recently
from
January 16, 2025 22:17
3206fbc
to
8dc1c72
Compare
hk21702
force-pushed
the
UDENG-5705-Ubuntu-Insights-Consent-Manager
branch
3 times, most recently
from
January 17, 2025 14:48
693d04e
to
2e873d4
Compare
Sploder12
requested changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on the consent manager! Just some minor comments and questions from me.
internal/consent/testdata/consent_files/junkfolder/junk-consent.toml
Outdated
Show resolved
Hide resolved
hk21702
force-pushed
the
UDENG-5705-Ubuntu-Insights-Consent-Manager
branch
2 times, most recently
from
January 21, 2025 14:36
6613aa2
to
d6c9d77
Compare
hk21702
force-pushed
the
UDENG-5705-Ubuntu-Insights-Consent-Manager
branch
from
January 21, 2025 14:49
d6c9d77
to
1c7b560
Compare
hk21702
force-pushed
the
UDENG-5705-Ubuntu-Insights-Consent-Manager
branch
from
January 21, 2025 15:38
770c343
to
5ad0e21
Compare
Sploder12
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of the consent manager
UDENG-5705
Based off #2
Dependent on #7