feat(internal/collector): MULTI-1736 implement sysinfo collection on Windows #10
+2,717
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## collector-sysinfo-wip #10 +/- ##
=========================================================
+ Coverage 75.56% 79.74% +4.18%
=========================================================
Files 21 21
Lines 937 1111 +174
=========================================================
+ Hits 708 886 +178
+ Misses 189 182 -7
- Partials 40 43 +3 ☔ View full report in Codecov by Sentry. |
Sploder12
changed the title
Sploder12
force-pushed
the
collector-hardware-windows
branch
3 times, most recently
from
2ac9406 to
379cd35
Compare
Sploder12
force-pushed
the
collector-hardware-windows
branch
5 times, most recently
from
7501897 to
fc1f191
Compare
also modifies product collection a bit
Win32_PhysicalMemory would give us more information, but we currently only care about total physical memory.
A lot of info is missing. The physical size could be retrieved, but that command may be deprecated and associating that size to a particular monitor may not be stable.
The partition ones are important since we don't want out of bounds writes.
It would be bad if we allowed unreasonable amounts of partitions
Sploder12
force-pushed
the
collector-hardware-windows
branch
from
fc1f191 to
c6cda73
Compare
Sploder12
force-pushed
the
collector-hardware-windows
branch
from
c6cda73 to
0833cce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements system hardware information collection on Windows. The information collected includes Product, CPU, GPU, Memory, Block, and Screen as described by the spec with some exceptions. The exceptions are:
MULTI-1741