feat: improve the value of "active" in endpoint output to always cont…

…ain True or False

fence/resources/user/__init__.py

@@ -91,7 +91,9 @@ def get_user_info(current_session, username):
         "phone_number": user.phone_number,
         "email": user.email,
         "is_admin": user.is_admin,
-        "active": user.active,
+        "active": False
+        if user.active is False
+        else True,  # using "**is** False", since falsy None and True should both eval to True
         "role": role,
         "project_access": dict(user.project_access),
         "certificates_uploaded": [],

tests/admin/test_admin_users_endpoints.py

@@ -702,9 +702,14 @@ def test_soft_delete_user_username(
     deactivated user.
     """
     username = "test_user_d"
-    user = db_session.query(User).filter_by(username=username).one()
-    assert user.username == username
-    assert user.active is None
+    r = client.get(
+        f"/admin/users/{username}",
+        headers={"Authorization": "Bearer " + encoded_admin_jwt},
+    )
+    assert r.status_code == 200
+    assert r.json["username"] == username
+    assert r.json["active"] == True
+
     # now soft-delete and assert "active" changed to False:
     r = client.delete(
         f"/admin/users/{username}/soft",