Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: assigning ADFS groups claim from Cognito as Arborist resources/policies #1066

Closed
wants to merge 2 commits into from

Conversation

m0nhawk
Copy link
Contributor

@m0nhawk m0nhawk commented Jan 4, 2023

Jira Ticket: VADC-76

New Features

  • Creating Arborist resources based on the groups from claim for Cognito

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

@coveralls
Copy link

coveralls commented Jan 4, 2023

Pull Request Test Coverage Report for Build 13219

  • 14 of 59 (23.73%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 73.724%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fence/resources/openid/cognito_oauth2.py 1 2 50.0%
fence/resources/cognito/groups.py 4 10 40.0%
fence/blueprints/login/cognito.py 8 20 40.0%
fence/sync/sync_users.py 1 27 3.7%
Totals Coverage Status
Change from base Build 13208: -0.3%
Covered Lines: 6964
Relevant Lines: 9446

💛 - Coveralls

@m0nhawk m0nhawk closed this Nov 22, 2023
@m0nhawk m0nhawk deleted the feat/aws-cognito-claims branch November 22, 2023 16:53
@m0nhawk m0nhawk restored the feat/aws-cognito-claims branch December 5, 2023 16:27
@m0nhawk m0nhawk reopened this Dec 5, 2023
@m0nhawk m0nhawk force-pushed the feat/aws-cognito-claims branch from ff4c688 to 28d437f Compare December 5, 2023 16:31
@m0nhawk m0nhawk closed this Jul 18, 2024
@m0nhawk m0nhawk deleted the feat/aws-cognito-claims branch July 18, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants