Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: capitalization #1154

Closed
wants to merge 2 commits into from
Closed

feat: capitalization #1154

wants to merge 2 commits into from

Conversation

m0nhawk
Copy link
Contributor

@m0nhawk m0nhawk commented Jul 1, 2024

Link to JIRA ticket if there is one: VADC-1233

New Features

  • capitalization fixes for Cognito

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

@m0nhawk m0nhawk force-pushed the feat/capitalization branch from fb045e3 to 27f7b42 Compare July 1, 2024 22:00
@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9751523484

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.002%) to 75.049%

Files with Coverage Reduction New Missed Lines %
resources/ga4gh/passports.py 2 87.43%
resources/openid/cognito_oauth2.py 6 40.91%
Totals Coverage Status
Change from base Build 9713845019: -0.002%
Covered Lines: 7706
Relevant Lines: 10268

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9751803833

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 393 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.03%) to 75.02%

Files with Coverage Reduction New Missed Lines %
error_handler.py 1 95.74%
blueprints/login/utils.py 2 88.89%
resources/ga4gh/passports.py 2 87.43%
oidc/oidc_server.py 3 90.0%
resources/openid/cognito_oauth2.py 6 40.91%
oidc/grants/implicit_grant.py 7 32.14%
init.py 9 91.21%
blueprints/login/fence_login.py 10 74.07%
oidc/grants/oidc_code_grant.py 11 87.06%
oidc/grants/refresh_token_grant.py 12 67.5%
Totals Coverage Status
Change from base Build 9713845019: -0.03%
Covered Lines: 7622
Relevant Lines: 10160

💛 - Coveralls

Copy link

@jacob50231 jacob50231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes mostly look good! Maybe look into poetry vulnerability check before merging.

@m0nhawk
Copy link
Contributor Author

m0nhawk commented Jul 10, 2024

This is not really needed, all the changes are arborist-only: uc-cdis/arborist#165

@m0nhawk m0nhawk closed this Jul 10, 2024
@m0nhawk m0nhawk deleted the feat/capitalization branch July 10, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants