Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Image Change #1207

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

Docker Image Change #1207

wants to merge 44 commits into from

Conversation

BinamB
Copy link
Contributor

@BinamB BinamB commented Dec 13, 2024

Related PR: https://github.com/uc-cdis/cloud-automation/pull/2682/files

Without the cloud-auto PR, we're not able to successfully deploy fence.

Improvements

  • Update to use new Amazon Linux base image and use the same structure as our other python services.
  • Utilizing "gen3" user instead of "root" for more secure containers
  • Moving to Poetry to manage our virtual environments
  • Multi-stage Docker builds for smaller images
  • Move to Gunicorn

Copy link

Please find the ci env pod logs here

Copy link

Please find the ci env pod logs here

Copy link

Please find the ci env pod logs here

Copy link
Contributor

@nss10 nss10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Just a couple of questions, and will approve.

Dockerfile Outdated
libxcrypt-compat-4.4.33 \
libpq-15.0 && \
echo "Installing RPM"; \
rpm -i https://ccrypt.sourceforge.net/download/1.11/ccrypt-1.11-1.x86_64.rpm; \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed we are using an x86 binary for ARM. Will this be emulated for ARM during use? Has any testing been done to confirm its functionality?

pyproject.toml Outdated
@@ -22,7 +22,7 @@ cached_property = "^1.5.1"
cdiserrors = "<2.0.0"
cdislogging = "^1.0.0"
cdispyutils = "^2.0.1"
flask = ">=3.0.0"
flask = "^2.2.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clarify the reason for downgrading Flask?

Copy link

github-actions bot commented Jan 3, 2025

Please find the ci env pod logs here

Copy link

github-actions bot commented Jan 3, 2025

Please find the ci env pod logs here

Copy link

github-actions bot commented Jan 7, 2025

Please find the ci env pod logs here

@BinamB BinamB changed the title Chore/ccrypt usersync Update to use new Amazon Linux base image Jan 8, 2025
@BinamB BinamB changed the title Update to use new Amazon Linux base image Docker Image Change Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

Please find the ci env pod logs here

@jawadqur jawadqur marked this pull request as ready for review January 10, 2025 15:39
Copy link

Please find the ci env pod logs here

Dockerfile Outdated
RUN poetry lock -vv --no-update \
&& poetry install -vv --only main --no-interaction

ENV PATH="$(poetry env info --path)/bin:$PATH"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker does not support SHELL expansion of variables in ENV clause. The value of $(poetry env info --path) is taken as a literal string and is prepended to $PATH.

bash-5.2# echo $PATH
$(poetry env info --path)/bin:/home/gen3/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/root/.local/bin

Copy link

Please find the ci env pod logs here

Copy link

Please find the ci env pod logs here

Copy link

Please find the ci env pod logs here

Copy link

Please find the ci env pod logs here

Copy link

Please find the ci env pod logs here

Copy link

Please find the detailed integration test report here

Please find the ci env pod logs here

Copy link

Please find the ci env pod logs here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants