container: add a helper for test only #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoyer64
approved these changes
Feb 27, 2025
| @@ -120,3 +120,20 @@ func (ctn Writer) toWriter(header header, w io.Writer) (err error) { | |||
|
|
|||
| return ipld.EncodeStreaming(encoder, node, cbor.Encode) | |||
| } | |||
|
|
|||
| // ToReader convert a container Writer into a Reader. | |||
| // Most likely, you only want to use this in tests for convenience. | |||
There was a problem hiding this comment.
Most likely
Since it's not a test package, shouldn't we just return (io.Reader, error) and let the user decide?
There was a problem hiding this comment.
It's to a Reader, not an io.Reader.
There is really no reason to use those beside test where you do odd things. Otherwise you are only on the "writing" side or the "reading" side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.